fix: add lint rule to detect bare pip install and fix beval.yml violation - #2548
Open
PratikWayase wants to merge 1 commit into
Open
fix: add lint rule to detect bare pip install and fix beval.yml violation#2548PratikWayase wants to merge 1 commit into
PratikWayase wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds CI enforcement for the repo's uv-first Python convention by introducing a reusable lint workflow that detects bare
pip installcalls in workflows, scripts, and Python files. Fixes the one known existing violation inbeval.ymland updates experimental skill error strings to recommenduv pip install.Companion to #1313, which adds the corresponding prohibitions to the Python instruction files. Without this enforcement backstop, those rules have no CI validation and regressions can silently appear.
Related Issue(s)
Fixes #2500
Companion to #1313
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
hve-builderand addressed all actionable findings.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md).github/hooks/*/*.json)evals/)Other:
.ps1,.sh,.py)Testing
All 4 local test scenarios passed successfully:
python scripts/lint_pip_install.py→Success: No bare 'pip install' calls found.run: pip install malicious-packageinto a fake workflow → correctly flagged and exited 1.pip install mock-packageintoevals/fake_eval_test.py→ correctly ignored per acceptance criteria.run: uv pip install fastapiinto a fake workflow → correctly passed.Additionally verified that
.venvdirectories, YAMLname:metadata lines, andTHIRD-PARTY-NOTICESare properly excluded to prevent false positives.Checklist
Required Checks
AI Artifact Contributions
hve-builderreview mode to review contributionhve-builderreviewRequired Local Checks
npm run validate:local(N/A — no docs/PS/md changed)npm run validate:docs(N/A)npm run spell-check(N/A — no prose changed)npm run lint:md-links(N/A — no URLs added)Security Considerations
All GitHub Actions in new and modified workflows are SHA-pinned per repo convention:
actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83ddactions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97astral-sh/setup-uv@c771a70e6277c0a99b617c7a806ffedaca235ff9The
beval.ymlinstall remains pinned to commit SHAd9f46c24f03b0b806d928a8a8ce2fc66d8e470fbto mitigate supply-chain risk.Additional Notes
Files changed (7 total):
scripts/lint_pip_install.py.venv/evals/THIRD-PARTY-NOTICESexclusions.github/workflows/pip-install-lint.yml.github/workflows/pr-validation.ymlpip-install-lintjob calling the reusable workflow.github/workflows/beval.ymlpip installwithuv pip install --system, addedsetup-uvstep.github/skills/experimental/powerpoint/scripts/export_slides.pyuv pip install.github/skills/experimental/powerpoint/scripts/export_svg.pyuv pip install.github/skills/experimental/powerpoint/scripts/render_pdf_images.pyuv pip install